JENKINS-43746 Update step heading to include selected parallel and live duration #1211
Conversation
|
@NicuPascu just checking - this one still on cards? (labels seem set correctly, thanks for that) |
|
@michaelneale yes, is still work in progress because I couldn't make the TimeDuration component to work correctly so now the duration is only visible for a completed step, not while running, took some time off it to give myself some time to think about it, will try to finish it today |
|
@NicuPascu worth picking this one up again some time or has been made long irrelevant? (fine if it has) |
|
@michaelneale I got stuck on adding the live duration and then never gone back to it because of other tickets with higher priorities, I'll update this to master and give it another go |
|
@NicuPascu no worries, just saw the linked ticket. No rush if working on other things, just wanted to close it if wasn't relevant (I missed the ticket link for some reason..) |
|
There are bugs elsewhere in some of the live duration code, possibly related to the time haromizer stuff. May want to proceed carefully (or not at all) until we can address the harmonizer stuff in a better way. Happy to chat about it more if you're interested. |
NicuPascu
added
needs-review
and removed
DO NOT MERGE
help wanted
work-in-progress
labels
|
Looks great 👍 One minor change: can you add a space before and after the slash?
|
|
@i386 Done |
| @@ -73,7 +73,7 @@ function convertJenkinsNodeDetails(jenkinsNode, isCompleted, skewMillis = 0) { | |||
| } | |||
| const i18nDuration = timeManager.format(harmonized.durationInMillis, translate('common.date.duration.hint.format', { defaultValue: 'M [month], d [days], h[h], m[m], s[s]' })); | |||
|
|
|||
| const title = translate(`common.state.${state}`, { 0: i18nDuration }); | |||
| const title = state !== 'running' ? translate(`common.state.${state}`, { 0: i18nDuration }) : ''; | |||
There was a problem hiding this comment.
So we only want to have the duration as title when it's running? This might be clearer if you reverse the ternary to state == 'running' ? '' : translate(common.state.${state}, { 0: i18nDuration });
There was a problem hiding this comment.
No big deal tho, just took me a little bit to parse. But I'm slow :)
|
Code looks OK to me 🐝 IMO the time harmoniser dealie is pointless on durations, because they're scalar, and don't have a timezone. |
halkeye
deleted the
task/JENKINS-43746_update_step_heading_to_include_prallel
branch
Description
See JENKINS-43746.
Submitter checklist
Reviewer checklist